Update battery scripts

1 files changed, 10 insertions, 9 deletions

diff --git a/bat.sh b/bat.sh
index 071bb20..d1531b4 100755
--- a/bat.sh
+++ b/bat.sh
@@ -1,16 +1,17 @@
-#!/bin/bash
+#!/usr/bin/env bash
+
+set -euo pipefail
 
 ac_online=$(cat /sys/class/power_supply/AC/online)
 
-if [ "x$ac_online" = "x1" ] ; then
-    echo "On power"
+if [ "$ac_online" = 1 ]; then
+  echo "On power"
 fi
 
-for bat in /sys/class/power_supply/BAT? ; do
-    status=$(cat "$bat/status")
-    energy_full=$(cat "$bat/energy_full")
-    energy_now=$(cat "$bat/energy_now")
-    current_charge=$(bc <<< "scale=2; $energy_now / $energy_full * 100")
+for bat in /sys/class/power_supply/BAT?; do
+  energy_full=$(cat "$bat/energy_full")
+  energy_now=$(cat "$bat/energy_now")
+  current_charge=$(bc <<<"scale=2; $energy_now / $energy_full * 100")
 
-    printf '%s: %.0f%%\n' $(basename $bat) $current_charge
+  printf '%s: %.0f%%\n' "$(basename "$bat")" "$current_charge"
 done